A lot of people are sharing personal stories about interactions with John McCain on his death. And it is important that he seemed to treat constituents he disagreed with, and staffers for people on the other side of the aisle well. And his heroism as a POW is undeniable.
But while that’s important, it isn’t really how you should judge the legacy of an elected official. And on policy, he was garbage. He should be judged for his full throttle support of the Iraq war among many others. He should be judged for tax cuts for the wealthy, and fuckall for the poor. He had a few moments where he did good things (his ACA vote, saying Obama isn’t a secret Arab), but none of them would be the bare minimum if it was a Democrat.